Fix/inconsistent anomaly score #141
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quadra/tasks/anomaly.py
Outdated
| # The reason I have to expand dims and cast the optimal threshold to anomaly_scores dtype is because | ||
| # of internal roundings performed differently by numpy and python | ||
| # Particularly the normalized_optimal_threshold computed directly using float values might be higher than the | ||
| # actual value obtained by the anomaly_scores, as such the computed f1 score might be wrong in the UI!! |
quadra/utils/anomaly.py
Outdated
| # For all the items whose prediction changes after normalization, force the normalized score to be | ||
| # consistent with the prediction made on the raw score by clipping the score: | ||
| # - to 100.0 if the prediction was "anomaly" on the raw score and "good" on the normalized score | ||
| # - to 99.0 if the prediction was "good" on the raw score and "anomaly" on the normalized score |
Contributor
There was a problem hiding this comment.
Non cambia niente, ma se mettessimo 99.99 come default? Giusto per far capire che è un valore particolare
lorenzomammana
approved these changes
Dec 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Describe the purpose of the pull request, including:
Type of Change
Please select the one relevant option below:
Checklist
Please confirm that the following tasks have been completed: