Skip to content

Conversation

@2uan2
Copy link

@2uan2 2uan2 commented Dec 14, 2025

No description provided.

Copy link

@zeevmoney zeevmoney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @2uan2 thank you for the contribution, see my comments.

@zeevmoney zeevmoney requested a review from Copilot December 16, 2025 14:06
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds partial support for the Groups API to the SDK, enabling interaction with group-related endpoints including creation, deletion, user assignment, and role assignment operations.

Key Changes:

  • Implemented core GroupsApi class with CRUD operations and user/role assignment methods
  • Added supporting model classes (GroupRead, GroupCreate, GroupAssignUser, GroupAddRole) for API interactions
  • Created comprehensive E2E tests to validate the Groups API functionality

Reviewed changes

Copilot reviewed 10 out of 12 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
GroupsApi.java Core API implementation with methods for creating, retrieving, deleting groups, and managing user/role assignments
GroupRead.java Model class representing group data returned from API reads
GroupCreate.java Model class for creating new groups
GroupAssignUser.java Model class for assigning users to groups
GroupAddRole.java Model class for adding roles to groups
GroupsApiE2ETest.java End-to-end tests validating all Groups API operations
ApiClient.java Integration of GroupsApi instance into the main API client
ResourceRelationsApi.java Fixed typo in documentation comment
ResourceInstancesApi.java Added documentation clarifying method alias
ResourcesApiE2ETest.java Updated test comments for accuracy

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@zeevmoney zeevmoney requested a review from Copilot December 21, 2025 13:00
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated 3 comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@zeevmoney zeevmoney requested a review from Copilot December 21, 2025 14:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 10 out of 12 changed files in this pull request and generated 1 comment.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants