Unwind _inner call pattern in api object modules
#45
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
_innersystem pattern and moves a bit more coordination back intolib.rs.Originally, this pattern arose organically because it was annoying to work with explicit borrows over
World. Bevy provides theInparameter for systems which can be used when explicitly executing a system onWorld. This cleaned code up, but when refactoring things to live in modules, I had wanted to keeplib.rsas small as possible.However, this pattern is kind of ugly. There are a few cases where, particularly because of code re-use, we need to do a little bit more coordination, but for the most part we typically can just call the the system immediately, and it's cleaner to have
lib.rsdo this.This change should be basically mechanical and introduce no behavior changes. Please see the docs folder for some additional color here.