Handle flake8 issues in part of the codebase. #2643
+48
−32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Two flake8 issues are raised here which were already in the original code:
I suggest adding a # noqa: E271 in these cases, since I imagine they simply mimic the original equations |
ramaroesilva
commented
Dec 24, 2025
| # a better way to do it. | ||
| if isinstance(datetime_or_doy, pd.DatetimeIndex): | ||
| to_doy = tools._pandas_to_doy # won't be evaluated unless necessary | ||
| def to_datetimeindex(x): return x # noqa: E306 |
Contributor
Author
There was a problem hiding this comment.
E704 multiple statements on one line (def)
ramaroesilva
commented
Dec 24, 2025
| import pandas as pd | ||
| from scipy.integrate import trapezoid | ||
|
|
||
| from warnings import warn |
Contributor
Author
There was a problem hiding this comment.
F401 'warnings.warn' imported but unused
ramaroesilva
commented
Dec 24, 2025
| import numpy as np | ||
| import pandas as pd | ||
| from pvlib.tools import sind | ||
| from pvlib._deprecation import warn_deprecated |
Contributor
Author
There was a problem hiding this comment.
F401 'warnings.warn' imported but unused
ramaroesilva
commented
Dec 24, 2025
|
|
||
| # Explicit solutions where Gsh=0 | ||
| if np.any(idx_z): | ||
| V[idx_z] = a[idx_z] * np.log1p((IL[idx_z] - I[idx_z]) / I0[idx_z]) - \ |
Contributor
Author
There was a problem hiding this comment.
F401 'warnings.warn' imported but unused
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs/sphinx/source/whatsnewfor all changes. Includes link to the GitHub Issue with:issue:`num`or this Pull Request with:pull:`num`. Includes contributor name and/or GitHub username (link with:ghuser:`user`).remote-data) and Milestone are assigned to the Pull Request and linked Issue.Note: will update the whatsnew in the 2nd PR (IDing the two of them)