gh-142448: Disable JIT tracing when monitoring is enabled #142842
Merged
+17
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ython into fix_sys_monitoring_jit
Member
Author
|
@markshannon pinging for review please. |
Member
|
Any ideas for testing this? |
markshannon
approved these changes
Dec 23, 2025
Member
markshannon
left a comment
markshannon
left a comment
There was a problem hiding this comment.
This looks correct.
I'd like a test, but I'm happy to merge this if we can't come up with one.
Member
Author
|
@markshanno I have no clue how to reliably test this honestly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #142448
Sorry, there is no test as I can't produce something that is self-isolated. Furthermore, it seems this test only works with exceptions + monitoring, which is exceptionally hard to test for (pun intended).
I have verified this fixes both reproducers given by OP.
PyObject *_PyEval_EvalFrameDefault(PyThreadState *, _PyInterpreterFrame *, int): Assertion 'STACK_LEVEL() == 0' failed#142448