Skip to content

Conversation

@cknitt
Copy link
Member

@cknitt cknitt commented Dec 23, 2025

Fixes #8101

@pkg-pr-new
Copy link

pkg-pr-new bot commented Dec 24, 2025

Open in StackBlitz

rescript

npm i https://pkg.pr.new/rescript-lang/rescript@8102

@rescript/darwin-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-arm64@8102

@rescript/darwin-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/darwin-x64@8102

@rescript/linux-arm64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-arm64@8102

@rescript/linux-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/linux-x64@8102

@rescript/runtime

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/runtime@8102

@rescript/win32-x64

npm i https://pkg.pr.new/rescript-lang/rescript/@rescript/win32-x64@8102

commit: 8e05b8a

Copy link
Member

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good from afar.
There are no perf hits after this?

@cknitt
Copy link
Member Author

cknitt commented Dec 25, 2025

This looks good from afar. There are no perf hits after this?

There shouldn't be, I now even moved the one additional build_state.get_root_config().path.clone() into the error handling code.

@cknitt cknitt merged commit 4f8b945 into rescript-lang:master Dec 25, 2025
36 of 37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

rescript build panics when two modules have the same name

2 participants