Fix readme and compilation errors, added .keep files to avoid build e… #9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrors, improved the documentation
|
Thank you so much for putting them together. I would hate myself to go through all the steps again to figure out what to do. It's a shame that this PR is not accepted, in the meantime I've put together a walkthrough to install MulVAL that integrates your PR. Of course I credited you for the patch. Hopefully that's OK with you :) |
Author
|
Hi @kazum1kun, great walkthrough! |
MRColorR
approved these changes
Nov 9, 2023
MRColorR
left a comment
MRColorR
left a comment
There was a problem hiding this comment.
this should be merged as currently the code does not compile anymore and all the edits are simple and really fast to check
MRColorR
approved these changes
Nov 9, 2023
MRColorR
left a comment
MRColorR
left a comment
There was a problem hiding this comment.
this one too should be merged the correct package name is graphviz
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following PR fixes several compilation errors and improve the README documentation regarding the mulval compilation.
g++ (GCC) 11.2.0)