Migrate Danger to use danger-pr-comment workflow #970
+36
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dblock
force-pushed
the
migrate-danger-pr-comment
branch
2 times, most recently
from
00b9cd9 to
8d9ed57
Compare
dblock
force-pushed
the
migrate-danger-pr-comment
branch
from
8d9ed57 to
e36f5b8
Compare
numbata
reviewed
Dec 30, 2025
dblock
force-pushed
the
migrate-danger-pr-comment
branch
2 times, most recently
from
c8f4166 to
fc17695
Compare
Replaces manual Danger setup with reusable workflow from numbata/danger-pr-comment, following the pattern from slack-ruby/slack-ruby-client#581 and slack-ruby/slack-ruby-bot-server#181. - Add danger, danger-pr-comment, danger-changelog, and danger-toc to Gemfile - Update Dangerfile to import danger-pr-comment and add changelog.check! and toc.check! - Replace danger.yml workflow with reusable workflow pattern - Add danger-comment.yml workflow for PR comments 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
dblock
force-pushed
the
migrate-danger-pr-comment
branch
from
fc17695 to
07a05ab
Compare
numbata
reviewed
Dec 30, 2025
| expect(hidden_entity_definition).to include({ | ||
| 'type' => 'object', | ||
| 'properties' => {}, | ||
| 'required' => ['hidden_prop'] |
Contributor
There was a problem hiding this comment.
This is from last version of grape-swagger-entity.
Member
Author
There was a problem hiding this comment.
Looks like there are other problems with grape/HEAD, going to leave this alone for a little bit ...
Contributor
There was a problem hiding this comment.
We probably need a scheduled workflow that runs the specs periodically, so we catch breakages early and keep the gem healthy.
dblock
force-pushed
the
migrate-danger-pr-comment
branch
from
faaa3ec to
aeb6c7e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrates from manual Danger setup to reusable workflow using
danger-pr-comment, following the pattern from:Changes
danger,danger-pr-comment,danger-changelog, anddanger-tocto Gemfiledanger-pr-commentand addchangelog.check!andtoc.check!danger.ymlworkflow with reusable workflow pattern fromnumbata/danger-pr-commentdanger-comment.ymlworkflow for posting PR commentsTest plan
🤖 Generated with Claude Code