-
Notifications
You must be signed in to change notification settings - Fork 58
Bundled wheels: update hashes automatically #144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
94c3811 to
0fda222
Compare
| - "python --version" | ||
| - "pip install pdm tox" | ||
| - "pdm install --no-self" | ||
| - "pdm install -v --dev --no-self" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add the --dev flag to install the dev dependencies that are needed to run the scripts (requests)
| [[tool.bundled_libmediainfo.wheel]] | ||
| platform = "win32" | ||
| arch = "arm64" | ||
| blake2b_sums = "e9f426f2e873f65ca1fdede5f8eb6dc3e871e682b821ad3f62acb1428eda5a27ce363f77a2c621d1b15f8e9b94976a10afb56fc069325ca7ba4efad14df03105" | ||
| tag = "win_arm64" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
libmediainfo is compiled for windows arm64, it doesn't cost much to bundle a wheel for this architecture.
Well, it has to be added to appveyor.yaml
|
Sorry for the big PR, it was not as simple to implement as I first thought 😅 |
|
|
||
| # Custom entries for downloading the bundled libmediainfo | ||
| [tool.bundled_libmediainfo] | ||
| version = "24.12" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, I like the idea of having the variable stuff in a config file instead of a script :D
|
If you've used it before, is GitHUB's CI faster than AppVeyor? AppVeyor's 1 job limit makes it reaaaaaaally long to run the whole CI :/ |
|
Yes it's much faster... It also cancels jobs when a new commit is pushed in a PR, so you don't have to wait for outdated jobs to finish.
…On 12 February 2025 22:07:06 GMT+00:00, Louis Sautier ***@***.***> wrote:
If you've used it before, is GitHUB's CI faster than AppVeyor? AppVeyor's 1 job limit makes it reaaaaaaally long to run the whole CI :/
And I think you mentioned GH CI before :)
--
Reply to this email directly or view it on GitHub:
#144 (comment)
You are receiving this because you authored the thread.
Message ID: ***@***.***>
|
0fda222 to
3a17977
Compare
d199716 to
ad409c4
Compare
|
The test that needs libcurl.dll is still failing on windows, I will revert the changes, it will simplify |
382f101 to
7c20f58
Compare
…tform and arch selection
7c20f58 to
f491d3b
Compare
Follow-up to #141 (comment)
This PR adds a script to update the version of the bundled libmediainfo library and to update the checksums of the files to download from MediaInfo.
Instead of hard-coding the mediainfo version and hashes in the
download_library.pyscript, this information is put inpyproject.toml. Then the newupdate_checksums.pyscripts is used to update the values in thepyproject.tomlconfig file.A typical workflow to regenerate bundled wheels with the latest MediaInfo version, for all the platforms and architectures: