Skip to content

Conversation

@getzze
Copy link
Contributor

@getzze getzze commented Feb 12, 2025

Follow-up to #141 (comment)

This PR adds a script to update the version of the bundled libmediainfo library and to update the checksums of the files to download from MediaInfo.

Instead of hard-coding the mediainfo version and hashes in the download_library.py script, this information is put in pyproject.toml. Then the new update_checksums.py scripts is used to update the values in the pyproject.toml config file.

A typical workflow to regenerate bundled wheels with the latest MediaInfo version, for all the platforms and architectures:

pdm run update_checksums
pdm run build_all

- "python --version"
- "pip install pdm tox"
- "pdm install --no-self"
- "pdm install -v --dev --no-self"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add the --dev flag to install the dev dependencies that are needed to run the scripts (requests)

Comment on lines 96 to 97
[[tool.bundled_libmediainfo.wheel]]
platform = "win32"
arch = "arm64"
blake2b_sums = "e9f426f2e873f65ca1fdede5f8eb6dc3e871e682b821ad3f62acb1428eda5a27ce363f77a2c621d1b15f8e9b94976a10afb56fc069325ca7ba4efad14df03105"
tag = "win_arm64"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

libmediainfo is compiled for windows arm64, it doesn't cost much to bundle a wheel for this architecture.
Well, it has to be added to appveyor.yaml

@getzze
Copy link
Contributor Author

getzze commented Feb 12, 2025

Sorry for the big PR, it was not as simple to implement as I first thought 😅


# Custom entries for downloading the bundled libmediainfo
[tool.bundled_libmediainfo]
version = "24.12"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, I like the idea of having the variable stuff in a config file instead of a script :D

@sbraz
Copy link
Owner

sbraz commented Feb 12, 2025

If you've used it before, is GitHUB's CI faster than AppVeyor? AppVeyor's 1 job limit makes it reaaaaaaally long to run the whole CI :/
And I think you mentioned GH CI before :)

@getzze
Copy link
Contributor Author

getzze commented Feb 12, 2025 via email

@getzze
Copy link
Contributor Author

getzze commented Feb 13, 2025

The test that needs libcurl.dll is still failing on windows, I will revert the changes, it will simplify dowload_library code.
I think it's better to just skip this test on Windows systems.

@getzze getzze force-pushed the update-checksums branch 2 times, most recently from 382f101 to 7c20f58 Compare February 14, 2025 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants