Skip to content

[GitHub] Improve workflow for Ubuntu and MacOS #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnbrunet merged 16 commits into from
Jul 30, 2021
Merged

[GitHub] Improve workflow for Ubuntu and MacOS #157

jnbrunet merged 16 commits into from
Jul 30, 2021

Conversation

@guparan
Copy link
Contributor

@guparan guparan commented Jul 28, 2021 •
edited
Loading

TO BE SQUASHED

@guparan guparan added enhancement New feature or request pr: status to review labels Jul 28, 2021
@guparan guparan mentioned this pull request Jul 29, 2021
Merged
@guparan guparan force-pushed the ci_improve_workflows branch from c801b08 to 797dd3a Compare July 29, 2021 15:36
@guparan guparan force-pushed the ci_improve_workflows branch from 797dd3a to ef6c3b6 Compare July 29, 2021 16:21
@guparan guparan force-pushed the ci_improve_workflows branch 2 times, most recently from 21b1acc to 63d7a0e Compare July 29, 2021 17:19
@guparan guparan force-pushed the ci_improve_workflows branch from 9aad1c3 to 3f096a7 Compare July 30, 2021 10:58
@guparan guparan force-pushed the ci_improve_workflows branch from 758a65d to 895ef0f Compare July 30, 2021 14:50
@guparan guparan force-pushed the ci_improve_workflows branch from 895ef0f to 92a9aae Compare July 30, 2021 14:55
@guparan
Copy link
Contributor Author

guparan commented Jul 30, 2021

Well well well @jnbrunet, isn't that a SUPER GREEN dashboard? 🎉

jnbrunet
jnbrunet approved these changes Jul 30, 2021
View reviewed changes
Copy link
Contributor

@jnbrunet jnbrunet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like you've now mastered github workflows !!

@jnbrunet jnbrunet merged commit 935f1f0 into sofa-framework:master Jul 30, 2021
@guparan guparan added this to the v21.06 milestone Oct 26, 2021
@guparan guparan deleted the ci_improve_workflows branch November 18, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jnbrunet jnbrunet jnbrunet approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request pr: status ready

Projects

None yet

Milestone

v21.06

Development

Successfully merging this pull request may close these issues.

2 participants

@guparan @jnbrunet