Support unpacking tuple return values by default #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dlangerm
force-pushed
the
dlangerm/support-tuple-returns
branch
from
f251c9f to
3d10cbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Returning tuples is a standard way of returning multiple things from a single function in python. Currently it is verbose to define a named tuple for every return type, additionally, named tuples have their own scope separate from the function which may not always be desired.
This PR allows returning tuples of annotated tensors to be properly checked.
Testing
Please select all that apply.
Test instructions
Unit tests
Resolves #23