Skip to content

Conversation

@tarappo
Copy link
Owner

@tarappo tarappo commented Mar 15, 2025

TODO

  • actionlintを追加

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new GitHub Actions workflow to lint GitHub Actions workflows using actionlint, along with an additional linting step using pinact-actions.

  • Introduces a new workflow file (.github/workflows/actionlint.yml).
  • Configures concurrency settings and permissions for the workflow.
  • Uses pinned commit hashes for action versions to ensure reproducibility.
Comments suppressed due to low confidence (2)

.github/workflows/actionlint.yml:13

  • Using 'write-all' permissions may be overly broad for this workflow. Consider limiting permissions to only what's necessary.
permissions: write-all

.github/workflows/actionlint.yml:21

  • [nitpick] Pinning the checkout action to a commit hash can delay receiving important security updates. Consider using a stable release tag like '@v4' to benefit from automatic fixes.
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2

@tarappo tarappo requested a review from Copilot March 15, 2025 08:17
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new GitHub Actions workflow for actionlint and updates existing workflows to use pinned commit versions of checkout and cache actions.

  • Introduces .github/workflows/actionlint.yml to run linting on workflow files.
  • Updates actions/checkout and actions/cache versions in pull_request and merge workflows.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
.github/workflows/actionlint.yml Adds linting workflow with actionlint setup.
.github/workflows/pull_request.yml Updates checkout and cache actions to pinned commits.
.github/workflows/merge.yml Updates checkout and cache actions to pinned commits.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@tarappo tarappo merged commit a3211f3 into main Mar 15, 2025
2 checks passed
@tarappo tarappo deleted the github_actions/use_actionlint branch March 15, 2025 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants