Skip to content

Conversation

@tarappo
Copy link
Owner

@tarappo tarappo commented May 11, 2025

TODO

  • サンプルコードの追加
  • READMEの用意
  • Fastfileへ実行対象として追加

@tarappo tarappo requested a review from Copilot May 11, 2025 06:28
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds sample code to support Xcode 16.3, including project configurations, tests, a SwiftUI application, and updated assets and documentation.

  • Updated the Fastfile to include a new Xcode16.3 project entry.
  • Added a new SwiftUI app structure, tests, and associated assets.
  • Provided updated README documentation with relevant release notes and testing topics.

Reviewed Changes

Copilot reviewed 10 out of 11 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Samples/fastlane/Fastfile Added a new project entry for Xcode16.3 configuration
Samples/Xcode16.3/xcode16.3Tests/xcode16_3Tests.swift Introduced new tests for environment, async behavior, and test scoping trait examples
Samples/Xcode16.3/xcode16.3/xcode16_3App.swift Created a basic SwiftUI app entry point
Samples/Xcode16.3/xcode16.3/xcode16_3.entitlements Added entitlements file for app sandbox configuration
Samples/Xcode16.3/xcode16.3/ContentView.swift Implemented a simple ContentView with preview support
Samples/Xcode16.3/xcode16.3/Assets.xcassets/Contents.json Added asset catalog info
Samples/Xcode16.3/xcode16.3/Assets.xcassets/AppIcon.appiconset/Contents.json Provided app icon asset configuration
Samples/Xcode16.3/xcode16.3/Assets.xcassets/AccentColor.colorset/Contents.json Added accent color set details
Samples/Xcode16.3/README.md Updated README with release notes and testing topics
Files not reviewed (1)
  • Samples/Xcode16.3/xcode16.3.xcodeproj/project.xcworkspace/contents.xcworkspacedata: Language not supported

@tarappo tarappo requested a review from Copilot May 11, 2025 06:46
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds sample code for Xcode 16.3 along with new tests, assets, and updates to CI configurations.

  • Introduces a new Xcode 16.3 project and corresponding test suite.
  • Updates fastlane and GitHub workflow configurations to use Xcode16.3.
  • Adds sample assets and a README for project documentation.

Reviewed Changes

Copilot reviewed 12 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
Samples/fastlane/Fastfile Added Xcode 16.3 project target alongside the existing one.
Samples/Xcode16.3/xcode16.3Tests/xcode16_3Tests.swift New test suite for Xcode 16.3 demonstrating environment and asynchronous tests.
Samples/Xcode16.3/xcode16.3/xcode16_3App.swift New SwiftUI app entry-point for the Xcode 16.3 sample.
Samples/Xcode16.3/xcode16.3/xcode16_3.entitlements Provision of entitlements for sandbox and file read-only permissions.
Samples/Xcode16.3/README.md Documentation and reference materials for the sample.
.github/workflows/pull_request.yml and merge.yml Updated DEVELOPER_DIR and runner labels to target Xcode16.3.
Assets.xcassets files Added assets configuration for the sample app.
Files not reviewed (1)
  • Samples/Xcode16.3/xcode16.3.xcodeproj/project.xcworkspace/contents.xcworkspacedata: Language not supported
Comments suppressed due to low confidence (2)

Samples/Xcode16.3/xcode16.3Tests/xcode16_3Tests.swift:11

  • The type name 'xcode16_3Tests' starts with a lowercase letter; consider renaming it to 'Xcode16_3Tests' to follow Swift naming conventions.
struct xcode16_3Tests {

Samples/Xcode16.3/xcode16.3/xcode16_3App.swift:11

  • The type name 'xcode16_3App' should start with an uppercase letter according to Swift naming conventions; consider renaming it to 'Xcode16_3App'.
struct xcode16_3App: App {

@tarappo tarappo merged commit 7cca552 into main May 11, 2025
2 checks passed
@tarappo tarappo deleted the xcode16.3 branch May 11, 2025 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants