Fix: Handle missing worker processes on shutdown #564
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added exception handling for ProcessLookupError when killing worker processes during shutdown. Now logs if a process is already terminated, improving robustness and clarity in process management.
Moved the worker shutdown code into a new _shutdown_workers() method in ProcessManager to improve code reuse and readability. The start() method now calls this helper when handling ShutdownAction.
s3rius
approved these changes
Dec 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added exception handling for ProcessLookupError when killing worker processes during shutdown. Now logs if a process is already terminated, improving robustness and clarity in process management.