Skip to content

fix: remove CRTP #11

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tinysec merged 30 commits into from
Nov 27, 2025
Merged

fix: remove CRTP #11

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
c7784c8
fix: InstructionTextLine
tinysec Nov 27, 2025
5954d6c
Instruction
tinysec Nov 27, 2025
84aec1b
Instructions
tinysec Nov 27, 2025
ab97959
feat: add equals for InstructionInfo
tinysec Nov 27, 2025
a4c5177
feat: asm level Instruction
tinysec Nov 27, 2025
3f72b4f
fix: simple name
tinysec Nov 27, 2025
0efa2b3
feat: asm level to low level
tinysec Nov 27, 2025
55ac38c
feat: HighLevelILExpressions
tinysec Nov 27, 2025
dbe8e47
x
tinysec Nov 27, 2025
2fd0eef
feat: MediumLevelILInstructions for low il
tinysec Nov 27, 2025
4b18922
feat: HighLevelILInstructions for low level
tinysec Nov 27, 2025
99e78c8
feat: high il fro medium
tinysec Nov 27, 2025
10f0eb9
feat: MediumLevelILExpression
tinysec Nov 27, 2025
c16d08d
feat: add medium and high il map
tinysec Nov 27, 2025
5ea46b7
fix: MustGetInstructions
tinysec Nov 27, 2025
41dbc09
fix: extra line
tinysec Nov 27, 2025
45c67c7
fix: remove blank
tinysec Nov 27, 2025
f6c4bf8
fix: remove CRTP
tinysec Nov 27, 2025
f41a9bf
feat: ChooseVariable
tinysec Nov 27, 2025
2f554b4
ChoosePluginCommand
tinysec Nov 27, 2025
a267d03
feat: ChoosePluginCommand
tinysec Nov 27, 2025
8fe12b8
feat: ChoosePlatform
tinysec Nov 27, 2025
8564449
feat: HighlightColor
tinysec Nov 27, 2025
5370a17
BNSetAutoFunctionParameterVariables
tinysec Nov 27, 2025
ab263fb
feat: SetAutoCanReturn
tinysec Nov 27, 2025
7a1202e
Callees
tinysec Nov 27, 2025
06e42a3
feat: ChooseCaller
tinysec Nov 27, 2025
82d9b2f
x
tinysec Nov 27, 2025
49a2bf6
xx
tinysec Nov 27, 2025
e64ba55
temp
tinysec Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,4 @@ bin/
dist/
build/
Folder.DotSettings.user
temp/
2 changes: 1 addition & 1 deletion Function/BNCreateAutoStackVariable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ internal static extern void BNCreateAutoStackVariable(
long offset ,

// BNTypeWithConfidence* type
IntPtr type ,
in BNTypeWithConfidence type ,

// const char* name
string name
Expand Down
4 changes: 2 additions & 2 deletions Function/BNCreateAutoVariable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ internal static extern void BNCreateAutoVariable(
IntPtr func ,

// BNVariable* _var
IntPtr _var ,
in BNVariable _var ,

// BNTypeWithConfidence* type
IntPtr type ,
in BNTypeWithConfidence type ,

// const char* name
string name ,
Expand Down
2 changes: 1 addition & 1 deletion Function/BNCreateUserStackVariable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ internal static extern void BNCreateUserStackVariable(
long offset ,

// BNTypeWithConfidence* type
IntPtr type ,
in BNTypeWithConfidence type ,

// const char* name
string name
Expand Down
4 changes: 2 additions & 2 deletions Function/BNCreateUserVariable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,10 @@ internal static extern void BNCreateUserVariable(
IntPtr func ,

// BNVariable* _var
IntPtr _var ,
in BNVariable _var ,

// BNTypeWithConfidence* type
IntPtr type ,
in BNTypeWithConfidence type ,

// const char* name
string name ,
Expand Down
2 changes: 0 additions & 2 deletions Function/BNDeleteAutoStackVariable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNDeleteAutoStackVariable"
)]
internal static extern void BNDeleteAutoStackVariable(
Expand All @@ -23,7 +22,6 @@ internal static extern void BNDeleteAutoStackVariable(

// int64_t offset
long offset

);
}
}
2 changes: 0 additions & 2 deletions Function/BNDeleteUserStackVariable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNDeleteUserStackVariable"
)]
internal static extern void BNDeleteUserStackVariable(
Expand All @@ -23,7 +22,6 @@ internal static extern void BNDeleteUserStackVariable(

// int64_t offset
long offset

);
}
}
4 changes: 1 addition & 3 deletions Function/BNDeleteUserVariable.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNDeleteUserVariable"
)]
internal static extern void BNDeleteUserVariable(
Expand All @@ -22,8 +21,7 @@ internal static extern void BNDeleteUserVariable(
IntPtr func ,

// BNVariable* _var
IntPtr _var

in BNVariable _var
);
}
}
2 changes: 0 additions & 2 deletions Function/BNGetCalleeForAnalysis.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNGetCalleeForAnalysis"
)]
internal static extern IntPtr BNGetCalleeForAnalysis(
Expand All @@ -29,7 +28,6 @@ internal static extern IntPtr BNGetCalleeForAnalysis(

// bool exact
bool exact

);
}
}
2 changes: 0 additions & 2 deletions Function/BNGetInstructionHighlight.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNGetInstructionHighlight"
)]
internal static extern BNHighlightColor BNGetInstructionHighlight(
Expand All @@ -26,7 +25,6 @@ internal static extern BNHighlightColor BNGetInstructionHighlight(

// uint64_t addr
ulong addr

);
}
}
4 changes: 1 addition & 3 deletions Function/BNGetVariableType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNGetVariableType"
)]
internal static extern BNTypeWithConfidence BNGetVariableType(
Expand All @@ -22,8 +21,7 @@ internal static extern BNTypeWithConfidence BNGetVariableType(
IntPtr func ,

// BNVariable* _var
IntPtr _var

in BNVariable _var
);
}
}
2 changes: 0 additions & 2 deletions Function/BNIsCallInstruction.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNIsCallInstruction"
)]
internal static extern bool BNIsCallInstruction(
Expand All @@ -26,7 +25,6 @@ internal static extern bool BNIsCallInstruction(

// uint64_t addr
ulong addr

);
}
}
4 changes: 1 addition & 3 deletions Function/BNSetAutoFunctionCallingConvention.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNSetAutoFunctionCallingConvention"
)]
internal static extern void BNSetAutoFunctionCallingConvention(
Expand All @@ -22,8 +21,7 @@ internal static extern void BNSetAutoFunctionCallingConvention(
IntPtr func ,

// BNCallingConventionWithConfidence* convention
IntPtr convention

in BNCallingConventionWithConfidence convention
);
}
}
4 changes: 1 addition & 3 deletions Function/BNSetAutoFunctionCanReturn.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNSetAutoFunctionCanReturn"
)]
internal static extern void BNSetAutoFunctionCanReturn(
Expand All @@ -22,8 +21,7 @@ internal static extern void BNSetAutoFunctionCanReturn(
IntPtr func ,

// BNBoolWithConfidence* returns
IntPtr returns

in BNBoolWithConfidence returns
);
}
}
4 changes: 1 addition & 3 deletions Function/BNSetAutoFunctionHasVariableArguments.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNSetAutoFunctionHasVariableArguments"
)]
internal static extern void BNSetAutoFunctionHasVariableArguments(
Expand All @@ -22,8 +21,7 @@ internal static extern void BNSetAutoFunctionHasVariableArguments(
IntPtr func ,

// BNBoolWithConfidence* varArgs
IntPtr varArgs

in BNBoolWithConfidence varArgs
);
}
}
4 changes: 1 addition & 3 deletions Function/BNSetAutoFunctionParameterVariables.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNSetAutoFunctionParameterVariables"
)]
internal static extern void BNSetAutoFunctionParameterVariables(
Expand All @@ -22,8 +21,7 @@ internal static extern void BNSetAutoFunctionParameterVariables(
IntPtr func ,

// BNParameterVariablesWithConfidence* vars
IntPtr vars

in BNParameterVariablesWithConfidence vars
);
}
}
4 changes: 1 addition & 3 deletions Function/BNSetAutoFunctionPure.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNSetAutoFunctionPure"
)]
internal static extern void BNSetAutoFunctionPure(
Expand All @@ -22,8 +21,7 @@ internal static extern void BNSetAutoFunctionPure(
IntPtr func ,

// BNBoolWithConfidence* pure
IntPtr pure

in BNBoolWithConfidence pure
);
}
}
4 changes: 1 addition & 3 deletions Function/BNSetAutoFunctionReturnType.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNSetAutoFunctionReturnType"
)]
internal static extern void BNSetAutoFunctionReturnType(
Expand All @@ -22,8 +21,7 @@ internal static extern void BNSetAutoFunctionReturnType(
IntPtr func ,

// BNTypeWithConfidence* type
IntPtr type

in BNTypeWithConfidence type
);
}
}
4 changes: 1 addition & 3 deletions Function/BNSetAutoInstructionHighlight.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNSetAutoInstructionHighlight"
)]
internal static extern void BNSetAutoInstructionHighlight(
Expand All @@ -28,8 +27,7 @@ internal static extern void BNSetAutoInstructionHighlight(
ulong addr ,

// BNHighlightColor color
HighlightColor color

in BNHighlightColor color
);
}
}
4 changes: 1 addition & 3 deletions Function/BNSetUserInstructionHighlight.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@ internal static partial class NativeMethods
[DllImport(
"binaryninjacore",
CallingConvention = System.Runtime.InteropServices.CallingConvention.Cdecl,
CharSet = CharSet.Ansi,
EntryPoint = "BNSetUserInstructionHighlight"
)]
internal static extern void BNSetUserInstructionHighlight(
Expand All @@ -28,8 +27,7 @@ internal static extern void BNSetUserInstructionHighlight(
ulong addr ,

// BNHighlightColor color
HighlightColor color

in BNHighlightColor color
);
}
}
2 changes: 1 addition & 1 deletion Handle/BNActivity.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace BinaryNinja
{
public sealed class Activity : AbstractSafeHandle<Activity>
public sealed class Activity : AbstractSafeHandle
{
internal Activity(IntPtr handle , bool owner)
: base(handle , owner)
Expand Down
2 changes: 1 addition & 1 deletion Handle/BNAnalysisCompletionEvent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace BinaryNinja
{
public sealed class AnalysisCompletionEvent : AbstractSafeHandle<AnalysisCompletionEvent>
public sealed class AnalysisCompletionEvent : AbstractSafeHandle
{
internal AnalysisCompletionEvent(IntPtr handle , bool owner)
: base(handle , owner)
Expand Down
2 changes: 1 addition & 1 deletion Handle/BNAnalysisContext.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace BinaryNinja
{
public sealed class AnalysisContext : AbstractSafeHandle<AnalysisContext>
public sealed class AnalysisContext : AbstractSafeHandle
{
internal AnalysisContext(IntPtr handle , bool owner)
: base(handle , owner)
Expand Down
2 changes: 1 addition & 1 deletion Handle/BNAnalysisMergeConflict.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@

namespace BinaryNinja
{
public sealed class AnalysisMergeConflict : AbstractSafeHandle<AnalysisMergeConflict>
public sealed class AnalysisMergeConflict : AbstractSafeHandle
{
internal AnalysisMergeConflict(IntPtr handle , bool owner)
: base(handle , owner)
Expand Down
2 changes: 1 addition & 1 deletion Handle/BNAnalysisMergeConflictSplitter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

namespace BinaryNinja
{
public sealed class AnalysisMergeConflictSplitter : AbstractSafeHandle<AnalysisMergeConflictSplitter>
public sealed class AnalysisMergeConflictSplitter : AbstractSafeHandle
{
internal AnalysisMergeConflictSplitter(IntPtr handle)
:base(handle, false)
Expand Down
Loading