-
-
Notifications
You must be signed in to change notification settings - Fork 14
Add country flags #136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add country flags #136
Conversation
|
If this is indeed the interface we want to provide to the end user, we may want to generate the variants automatically from a list of country codes instead of hardcoding them. If instead we hardcode all codes like in this pull request, I wouldn't feel confident merging it unless we add a test that makes sure all |
|
@MDLC01 i have generated the ascii codes by subtracting a value from regional indicators. i can assure you all of them are correct. checking those, however, might be a good idea |
|
Having it explicitly in the module source and having a test that runs an automatic check is indeed the way it should be done, and already has precedence with the variation selectors. |
|
Something like That way |
|
This is also a possibility but it would be much more verbose, and still annoying to check manually. I think a test would be better. |
I was thinking both. That being said, isn't there some crate we can use as a source of truth about valid regional sequences? To avoid having to hard code everything. |
|
@Enivex the unicode data: https://www.unicode.org/Public/emoji/latest/emoji-sequences.txt |
|
Interesting, I did not think Unicode provided an almost exhaustive list of flag sequences. Then I think it would be better to generate the flag variants automatically based on that. |
[I think the title and the commit describe enough.]