Skip to content

Conversation

@shimwell
Copy link
Collaborator

@shimwell shimwell commented May 14, 2021

Proposed changes

This is not ready for the review

This is my first partly working conda install, it can be built using

conda-build conda/ -c cadquery -c conda-forge --croot /tmp/conda-build

This is build but failing neutronics tests. So I shall pick this up again once neutronics has been removed

Types of changes

What types of changes does your code introduce to the Paramak?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code refactoring
  • Documentation Update (if none of the other choices apply)
  • New tests

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Pep8 applied
  • Unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link

codecov bot commented May 20, 2021

Codecov Report

Merging #843 (eb298c0) into develop (ddcfff3) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #843   +/-   ##
========================================
  Coverage    94.68%   94.68%           
========================================
  Files           75       75           
  Lines         5404     5404           
========================================
  Hits          5117     5117           
  Misses         287      287           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ddcfff3...eb298c0. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants