run modernize & gofix on full codebase #103
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make gopls's modernization checks happy by running golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize on the whole codebase.
go run golang.org/x/tools/internal/gofix/cmd/gofix@latest -fix -test ./... inline all the deprecated stdlib things.
Upgrade setup-go and checkout to the latest versions and add go 1.25 to the test matrix.
sergiosalvatore
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
run x/tools/...modernize
Make gopls's modernization checks happy by running
golang.org/x/tools/gopls/internal/analysis/modernize/cmd/modernize on
the whole codebase.
x/tools/.../gofix across the repo
go run golang.org/x/tools/internal/gofix/cmd/gofix@latest -fix -test ./...
inline all the deprecated stdlib things.
Add go 1.25 to the github actions test-matrix and upgrade the setup-go and checkout steps