flatten mangler: propagate an allow-list of tags #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a way for the flatten mangler to be configured to propagate particular tags as it descends. Notably, this will be useful for the flag, pflag and env sources so flags/env-vars can be disabled at a higher level when interacting with types you don't control. (and in some cases allow one to override a flag-name when embedding a type which will only generate a single flag)
Make it possible to default these tags at a higher-level.
dfinkel
force-pushed
the
flags_skip_intermediate
branch
from
1ef64ef to
5d5d885
Compare
sergiosalvatore
approved these changes
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
transform: teach flatten mangler to propagate tags
Add a way for the flatten mangler to be configured to propagate
particular tags as it descends.
Notably, this will be useful for the flag, pflag and env sources
so flags/env-vars can be disabled at a higher level when interacting
with types you don't control. (and in some cases allow one to override a
flag-name when embedding a type which will only generate a single flag)
sources: propagate dials{flag,pflag,desc,env}
Make it possible to default these tags at a higher-level.