feat: add X-Error-Message header to support error message reporting for package downloads #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbermudezsonatype
force-pushed
the
http2-error-msg-header
branch
from
d0fefc6 to
4dec08f
Compare
…or package downloads Enable HTTP servers to provide detailed error messages for failed package downloads via the X-Error-Message request header. This improves diagnostics when downloads fail on the server-side. Benefits: - Server flexibility: Repository administrators can communicate specific failure reasons to R users - Better user experience: Actionable error messages instead of generic HTTP status codes (e.g., "Requested item is quarantined" vs "403") - Standards-compliant: Uses standard HTTP header mechanism Implementation: C-level changes (libcurl.c): - Added url_error_context struct to store per-URL error messages - Implemented rcvErrorHeader() callback to capture X-Error-Message header (case-insensitive, up to 512 chars) - Extended download_report_url_error() to include custom error messages in warnings when available - Added error context lifecycle management (allocation, cleanup) for concurrent downloads - Each concurrent download maintains isolated error context via per-URL array indexing and CURLOPT_HEADERDATA R-level changes (packages.R): - Enhanced download.packages() to capture C-level warnings using withCallingHandlers() Safety fixes: - Fixed stack check calculation: Added missing sizeof(double) for tstart array in R_CheckStack2 (pre-existing issue) Testing: - Added backward compatibility tests to tests/download.file.R - Verified with servers sending X-Error-Message header - Tested concurrent downloads (install.packages with multiple packages) - Confirmed backward compatibility with servers not sending the header - Validated proper memory cleanup and per-URL context isolation Technical details: - Header parsing handles case-insensitive matching per HTTP spec - Truncates messages exceeding 512 characters - Minimal performance impact: only allocates context when needed
jbermudezsonatype
force-pushed
the
http2-error-msg-header
branch
from
4dec08f to
dd68bf9
Compare
|
(I think you know this since you've posted to Are you aware that this is a one-way mirror of the R code base, i.e. that pull requests here aren't noted by the R developers? The |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable HTTP servers to provide detailed error messages for failed package downloads via the X-Error-Message request header. This improves diagnostics when downloads fail on the server-side.
Benefits:
Implementation:
C-level changes (libcurl.c):
R-level changes (packages.R):
Testing:
Technical details: