-
-
Notifications
You must be signed in to change notification settings - Fork 35
Bring in Packager and make console commands extendable #197
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
LukeTowers
wants to merge
42
commits into
develop
Choose a base branch
from
wip/support-uploading-packages-update-manager-changes
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
42 commits
Select commit
Hold shift + click to select a range
95d734a
Added event/extension support to base command
jaxwilko 5d60632
Added support for module service provider instances to be bound to th…
jaxwilko 93882da
Migrated code from winter to storm
jaxwilko 407e842
Added local remember function to avoid system cache
jaxwilko 48eddec
Added base methods for modules to inherit
jaxwilko b1d4f06
Added packager to storm deps
jaxwilko 6b03b16
Added identifier and path logic to module provider
jaxwilko 43f0339
Added method for retrieving packages from composer api
jaxwilko ce22bcf
Update src/Console/Command.php
jaxwilko 6071790
Update src/Console/Command.php
jaxwilko 1faeaf0
Manual merge develop
jaxwilko 156529d
Added fix for symfony compatibility
jaxwilko d8f6d8b
Added helper to composer to allow fetching of installed winter packag…
jaxwilko eaf25e1
Merge branch 'develop' into wip/support-uploading-packages-update-man…
LukeTowers 1ce4f4b
Update src/Console/Command.php
LukeTowers 90ba47a
Revert change to HandlesCleanup
LukeTowers ecafe94
Cleanup
LukeTowers 6c2872c
Fixes for latest version of packager
LukeTowers 835d803
Added useful data to return from getAvailableUpdates
jaxwilko 82c251d
Added fixes for show command
jaxwilko 3a6a7e1
Added fix to prevent empty data being cached and removed the show com…
jaxwilko 699951e
Added fixes to command and added helper for updating package version …
jaxwilko 1dd8e84
Update src/Packager/Commands/InfoCommand.php
LukeTowers b0de374
Remove unnecessary packager overrides
LukeTowers 0803397
Remove unused Search command
LukeTowers 6f2b4f7
Replace customized RequireCommand with Composer::getLatestSupportedVe…
LukeTowers 2f6f264
Remove customized Update command
LukeTowers 4d90597
Update composer.json
LukeTowers acc4eef
Rename command beforeRun local event to command.beforeRun and documen…
LukeTowers b34c72f
Merge branch 'wip/support-uploading-packages-update-manager-changes' …
LukeTowers dc4b910
Update imports
LukeTowers bdbb0a0
Update src/Packager/Composer.php
LukeTowers 4e93a98
Move listPackages to Bazaar
LukeTowers 6f0b906
Merge branch 'wip/support-uploading-packages-update-manager-changes' …
LukeTowers d1aa548
Tidying
LukeTowers 79abfb7
Static analysis fixes
LukeTowers 969a1a7
Tidying
LukeTowers 2594bdf
Improve performance of working with Composer
LukeTowers ad5ca6c
Fix getting composer package version
LukeTowers 55ef0af
Fix usage of composer
LukeTowers 4760936
Fix PHP Stan
LukeTowers cb77bd5
Update src/Support/ModuleServiceProvider.php
LukeTowers File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| <?php | ||
|
|
||
| namespace Winter\Storm\Foundation\Extension; | ||
|
|
||
| interface WinterExtension | ||
| { | ||
| public function getPath(): string; | ||
|
|
||
| public function getVersion(): string; | ||
|
|
||
| public function getIdentifier(): string; | ||
|
|
||
| public function getComposerPackageName(): ?string; | ||
|
|
||
| public function getComposerPackageVersion(): ?string; | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully we can eliminate the need for this.