fix: blank shared blueprint visible in logic section - AB-848

[as-flow]

Summary by CodeRabbit

• Bug Fixes
  • Refined sidebar blueprint filtering logic to apply more precise categorization rules. Blueprint items are now correctly displayed in their appropriate sections with improved visibility, while maintaining proper separation between shared and non-shared blueprint categories.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

📝 Walkthrough

Walkthrough

Modified the type-filtering logic in BuilderSidebarToolkit to exclude only the specific type "blueprints_shared" instead of all types starting with "shared_". This targeted exclusion prevents blank Shared Blueprints from appearing in the logic section while allowing other shared-prefixed types to be included in their respective categories.

Changes

Cohort / File(s)	Summary
Filter Logic Update src/ui/src/builder/sidebar/BuilderSidebarToolkit.vue	Changed exclusion filter from type.startsWith("shared_") to exact type match "blueprints_shared". Narrows scope of filtered types, addressing visibility of blank Shared Blueprints in logic sections while preserving other shared\* type handling.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Suggested reviewers

• madeindjs
• UladzislauK-Writer

Poem

🐰 A blueprint was hiding where it shouldn't dwell,
In logic's neat section—that wouldn't be swell!
A filter refined, now precise and so tight,
Shared blueprints stay tucked, and the logic shines bright! ✨

Pre-merge checks

✅ Passed checks (5 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly references the specific issue (AB-848) and describes the main fix: preventing blank shared blueprints from appearing in the logic section.
Linked Issues check	✅ Passed	The PR addresses AB-848 by modifying the exclusion filter from broad 'shared_*' types to specific 'blueprints_shared' type, which should prevent unwanted shared blueprints from appearing in logic section.
Out of Scope Changes check	✅ Passed	The single code change in BuilderSidebarToolkit.vue directly targets the reported issue by refining the filtering logic for shared blueprint exclusion.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

📜 Recent review details

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

• Jira integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between f2793f4 and f6196d8.

📒 Files selected for processing (1)

• src/ui/src/builder/sidebar/BuilderSidebarToolkit.vue

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (8)

• GitHub Check: tests (chromium)
• GitHub Check: tests (firefox)
• GitHub Check: tests (webkit)
• GitHub Check: build (3.13)
• GitHub Check: build (3.10)
• GitHub Check: build (3.9)
• GitHub Check: build (3.11)
• GitHub Check: build (3.12)

🔇 Additional comments (1)

src/ui/src/builder/sidebar/BuilderSidebarToolkit.vue (1)

286-286: Targeted exclusion is correct.

The change from filtering all types starting with "shared_" to only the exact type "blueprints_shared" is the right approach. The codebase contains no other component types with a "shared_" prefix, and shared blueprint instances use synthetic types with the format blueprints_shared:${id} which don't appear in getSupportedComponentTypes(). Only the base "blueprints_shared" type needs exclusion from regular categories, allowing it to be handled specially in the "Shared Blueprints" category (lines 251-282).

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[pullrequest]

HackerOne Code Security Review

🟢 Scan Complete: 1 Issue(s)
🟢 Validation Complete: Any Issues detected were validated by one of our engineers. None were determined to require immediate action.

Here's how the code changes were interpreted and info about the tools used for scanning.

📖 Summary of Changes

The modification involves adjusting the component type filtering mechanism in the BuilderSidebarToolkit Vue component. The previous broad type check using `startsWith("shared_")` has been replaced with a more specific condition that explicitly checks for `"blueprints_shared"`. This change suggests a more precise approach to filtering tools within a category.

File	Summary
src/ui/src/builder/sidebar/BuilderSidebarToolkit.vue	The main change is in the component type filtering logic, where type.startsWith("shared_") was replaced with an explicit check for type === "blueprints_shared" in the getRelevantToolsInCategory function.

ℹ️ Issues Detected

NOTE: These may not require action!

Below are unvalidated results from the Analysis Tools that ran during the latest scan for transparency. We investigate each of these for accuracy and relevance before surfacing them as a potential problem.

How will I know if something is a problem?
When validation completes, any concerns that warrant attention prior to merge will be posted as inline comments. These will show up in 2 ways:

• Expert review (most cases): Issues will be posted by experts who manually reviewed and validated them. These are real HackerOne engineers (not bots) reviewing through an integrated IDE-like tool. You can communicate with them like any other reviewer. They'll stay assigned and get notified with commit & comment updates.
• Automatically: In cases where our validation checks have highest confidence the problem is legitimate and urgent. These will include a description of contextual reasoning why & actionable next steps.

File & Line	Issue
src/ui/src/builder/sidebar/BuilderSidebarToolkit.vue Line 286	The change modifies the filtering logic for component types. Previously, it filtered out any component type starting with 'shared_', but now it only filters out the specific type 'blueprints_shared'. This could potentially allow other components with names starting with 'shared_' to be displayed and used, which might expose functionality that was previously restricted.

🧰 Analysis tools

• [ ✅ ] HackerOne AI Code Analysis
• [ ✅ ] HackerOne AI Code Validation
• [ ✅ ] semgrep
• [ ✅ ] bandit

⏱️ Latest scan covered changes up to commit f6196d8 (latest)

[pullrequest]

✅ Graham C reviewed all the included code changes and associated automation findings and determined that there were no immediately actionable security flaws. Note that they will continue to be notified of any new commits or comments and follow up as needed throughout the duration of this pull request's lifecycle.

Graham C

---

Reviewed with ❤️ by PullRequest