add(toggle-pane) : add reset_state to set other restore state
#95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When restoring after max_preview, revert to the min-preview state
Member
|
Thanks for the PR @Jaehaks! I'd prefer not to add extra config. Is it possible to leverage the existing state to restore the view? When |
Author
|
This PR suggests returning to the reset state as the original behavior if we don't configure a default setup. Is that not enough? |
Member
|
Yes, that means the user needs to configure it.
I think it would feel more natural if you enter mode A but switch to mode B
without exiting, and then when you exit mode B, it restores to mode A, that
should be the default behavior.
…On Sat, Mar 22, 2025 at 5:46 PM Jaehaks ***@***.***> wrote:
This PR suggests returning to the reset state as the original behavior if
we don't configure a default setup. Is that not enough?
—
Reply to this email directly, view it on GitHub
<#95 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFWFIDFG5KP3E2OKWC3IED2VUWRHAVCNFSM6AAAAABZRPYUNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBVGE4DGOBUGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
[image: Jaehaks]*Jaehaks* left a comment (yazi-rs/plugins#95)
<#95 (comment)>
This PR suggests returning to the reset state as the original behavior if
we don't configure a default setup. Is that not enough?
—
Reply to this email directly, view it on GitHub
<#95 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEFWFIDFG5KP3E2OKWC3IED2VUWRHAVCNFSM6AAAAABZRPYUNKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDONBVGE4DGOBUGI>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Author
|
Ok i'll try it. please wait. i am not good at programming |
1. Problem - Back in the day, executing maximization again would always reset it to the default state laid out in the [manager] section of `yazi.toml` - 301f971 commit needs to additional configuration to change reset state 2. Improvement - Every minimization operation, it would save that state and then revert back to it after maximizing
Author
|
@sxyazi |
`bf_state` declared in entry() to remove setup()
sxyazi
force-pushed
the
main
branch
2 times, most recently
from
1ff5f8b to
4df8f70
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When restoring after max_preview, revert to the min-preview state
To resolve #94