-
Notifications
You must be signed in to change notification settings - Fork 17
Add use flag to include deprecated rpc functionality #54
base: 4.0
Are you sure you want to change the base?
Conversation
recipes/eglibc/eglibc.inc
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we have it for both native and machine, shouldn't we have it for sdk also?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We might also want to call it glibc_obsolete_rpc, preparing for using same flag on newer OE-lite/core.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should probably be added for sdk as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could also just add --enable-obsolete-rpc for both native and sdk always, as the minimal added size should not matter there.
|
Should add the same stuff to our master branch, and thus glibc 2.21? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a
DEFAULT_USE_eglibc_obsolete_rpc = "1"
line, to have this enabled by default? Or does it add considerably to footprint, so it makes sense to keep it disabled by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I cannot image it adds significant footprint. The reason I left it disabled by default is because it is deprecated.
The correct long term solution is to use libtirpc instead of rpc in (e)glibc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think Kim H would like the same functionality in the master branch in order to be able to use nfs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I think we should consider enabling it by default on the master branch (until we have libtirpc in place).
|
Force pushed changes. Added recipe flag to sdk and enabled as default. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could just have used OBSOLETE_RPC:USE_eglibc_obsolete_rpc but the result would have been the same.
|
The build fails when building rsync for powerpc From the log file: The "Copying srcdir rsync.1" output comes from Makefile.in and proto.h is part of the rsync package. It seems unrelated to the rpc change. Have you seen this before or do you have any ideas? |
|
It should be fixed by the fix merged to OE-lite/base 4.0 today. I will kick the buildbot to rebuild this PR again. |
|
I have noticed an issue with this. I set in my configuration file. This leads to when the recipe for eglibc is processed. For my current test build, I have removed eglibc_obsolete_rpc from RECIPE_FLAGS:>sdk: Which gets rid of the warning, but may not be what I really try to accomplish. Any suggestions? |
|
You could remove it from RECIPE_FLAGS:>native also. It does not seem relevant to either of them. |
Added use flag to enable/disable obsolete rpc support. USE_eglibc_obsolete_rpc Default is on Signed-off-by: Klaus Henning Sorensen <klaus.sorensen@prevas.dk>
|
I have force pushed a new version of this. The binaries that are built work for me. I have notice something odd though. If eglibc_obsolete_rpc is included in RECIPE_FLAGS:>native, non-working artifacts are built and some artifacts (including eglibc) are placed in tmp/work/machine/powerpc-e300c3-linux-gnu If eglibc_obsolete_rpc is not included in RECIPE_FLAGS:>native, working artifacts are built, and all build artifacts are placed in tmp/work/machine/powerpc-e300c3-linux-gnu.focondrm I do not know why adding a recipe flag for sdk builds causes this difference. |
|
Sounds strange, and quite disturbing. But in this case, I cannot see any reason what so ever for include eglibc_obsolete_rpc in RECIPE_FLAGS for native. Could you take a look at the resulting native:eglibc metadata, ie. and see where the MACHINE related powerpc-e300c3-linux-gnu is coming from? If it is not there, it might come from some of a native dependency that has been staged for native:eglibc. Be specially on the outlook for anything that relates to MACHINE* variables and native recipes. |
Add use flag to enable obsolete rcp support
This is necessary in order to be able to use nfs.
Signed-off-by: Klaus Henning Sorensen klaus.sorensen@prevas.dk