Skip to content
This repository was archived by the owner on Jan 27, 2019. It is now read-only.

Add use flag to include deprecated rpc functionality #54

Open
ksorensen wants to merge 1 commit into
base: 4.0
Choose a base branch
from
Open

Add use flag to include deprecated rpc functionality #54

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions recipes/eglibc/eglibc.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,14 +24,18 @@ LIBTOOL_DEPENDS = ""

MACHINE[unexport] = "1"

RECIPE_FLAGS:native = "toolchain_kernel_version_native"
RECIPE_FLAGS:machine = "toolchain_kernel_version_machine"
RECIPE_FLAGS:sdk = "toolchain_kernel_version_sdk"
RECIPE_FLAGS:>native = " toolchain_kernel_version_native eglibc_obsolete_rpc"
RECIPE_FLAGS:>machine = " toolchain_kernel_version_machine eglibc_obsolete_rpc"
RECIPE_FLAGS:>sdk = " toolchain_kernel_version_sdk"

DEFAULT_USE_toolchain_kernel_version_native = "2.6.32"
DEFAULT_USE_toolchain_kernel_version_machine = "2.6.32"
DEFAULT_USE_toolchain_kernel_version_sdk = "2.6.32"

Copy link
Contributor

@esben esben Oct 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add a
DEFAULT_USE_eglibc_obsolete_rpc = "1"
line, to have this enabled by default? Or does it add considerably to footprint, so it makes sense to keep it disabled by default?

Copy link
Contributor Author

@ksorensen ksorensen Oct 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I cannot image it adds significant footprint. The reason I left it disabled by default is because it is deprecated.

The correct long term solution is to use libtirpc instead of rpc in (e)glibc.

Copy link
Contributor Author

@ksorensen ksorensen Oct 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think Kim H would like the same functionality in the master branch in order to be able to use nfs.

Copy link
Contributor

@esben esben Oct 14, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I think we should consider enabling it by default on the master branch (until we have libtirpc in place).

OBSOLETE_RPC = ""
DEFAULT_USE_eglibc_obsolete_rpc = "1"
OBSOLETE_RPC:>USE_eglibc_obsolete_rpc = " --enable-obsolete-rpc"
Copy link
Contributor

@esben esben Oct 20, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You could just have used OBSOLETE_RPC:USE_eglibc_obsolete_rpc but the result would have been the same.


MIN_KERNEL_VERSION = "${USE_toolchain_kernel_version_native}${USE_toolchain_kernel_version_machine}${USE_toolchain_kernel_version_sdk}"
MIN_KERNEL_VERSION[expand] = "3"

Expand All @@ -47,6 +51,7 @@ EXTRA_OECONF += "\
--enable-kernel=${MIN_KERNEL_VERSION} \
--with-__thread \
--cache-file=config.cache \
${OBSOLETE_RPC} \
"

#ld-linux do NOT support RPATH. See get-dynamic-info.h within the eglibc src
Expand Down